Skip to content

Move clientid from pingreq to connection encapsulation #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move clientid from pingreq to connection encapsulation #99

wants to merge 1 commit into from

Conversation

icraggs
Copy link
Contributor

@icraggs icraggs commented Aug 11, 2025

No description provided.

@icraggs icraggs requested review from sthagen and lenzarda August 11, 2025 14:33
@icraggs icraggs self-assigned this Aug 11, 2025
sthagen
sthagen approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks also for the removal of the (certainly not matching any more) section number in the initial comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen sthagen approved these changes

@lenzarda lenzarda Awaiting requested review from lenzarda

Assignees

@icraggs icraggs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icraggs @sthagen