Skip to content

Conversation

HeikoTheissen
Copy link
Contributor

Fixes #2095

Comment on lines -289 to -296
Upon successful completion of the operation, the service creates the
requested entity and relates it to the requested existing entities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should retain this (as a MUST) because the intent was clearly to relate to the specified items.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we say MUST here, we treat "Link to Related Entities" (section 11.4.2.1) different from "Create Related Entities" (section 11.4.2.2).

Comment on lines +388 to +392
`Core.ContentID` for
the inserted or updated entities and MUST fail the request if an entity with associated
id cannot be created as intended by the client.
Other services that do not return the `Core.ContentID` MUST fail requests that contain a
[value reference](#ReferencingValuesfromResponseBodies) that uses this annotation value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have special handling for content-id, then this should apply to any scenario in which the client expects a particular instance to be created -- including things like client-supplied keys (and, perhaps, client-supplied alternate keys?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we are trying to distinguish between cases where the user expects specific entities to be created versus have the equivalent effect of the aggregate of the request.

through the
[`Capabilities.DeepUpdateSupport`]($$$OData-VocCap$$$#DeepUpdateSupport)
term, defined in [OData-VocCap](#ODataVocCap).
term, defined in [OData-VocCap](#ODataVocCap); services that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

A client specifies its intent to update the state of the system by making data modification requests
as described in the following subsections. The interpretation of
the client's intent during a successful completion of a data modification request
is up to the service, subject to the following rules:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer something like "The service may choose how to apply the client's intent, subject to the following rules:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep create - all or nothing
2 participants