Skip to content

Conversation

KaganCanSit
Copy link

Description

This PR fixes a syntax error in the C_UnwrapKeyAuthenticated function declaration in pkcs11f.h. The issue was a missing comma between the ulAssociatedDataLen parameter and the phKey parameter, which causes compilation failures.

Changes Made

  • Added missing comma after CK_ULONG ulAssociatedDataLen parameter in the C_UnwrapKeyAuthenticated function declaration

Error Details

The missing comma caused the following compilation error:
error: expected ',' or '...' before 'CK_OBJECT_HANDLE_PTR'
1325 | CK_OBJECT_HANDLE_PTR phKey
| ^~~~~~~~~~~~~~~~~~~~

Testing

  • Verified that the fix resolves the compilation error
  • Tested with GCC 12.2.0 on Linux x86_64 (Debian)
  • No functional changes, only syntax correction

References


This is a minor but critical fix that ensures the header files compile correctly across different compilers and platforms.

@KaganCanSit KaganCanSit mentioned this pull request Jun 1, 2025
@KaganCanSit
Copy link
Author

I am currently not a member of the OASIS PKCS#11 TC, but I would like to contribute and follow up the formal process. The membership links in the README currently return 503 (Service Unavailable). In the meantime, I leave this PR open as public feedback for TC members to review or consider for integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant