finishing-a-development-branch: hardcodes `gh pr create` without detecting platform (breaks on GitLab)

[glouie]

Bug

The finishing-a-development-branch skill hardcodes gh pr create for Option 2 (Push and Create PR) without first checking whether the repo is actually hosted on GitHub. On any other platform (GitLab, Bitbucket, self-hosted), gh fails with a confusing error and no PR/MR is created.

Reproduction

Run the skill on a repo whose remote points to a GitLab host (e.g. cd.splunkdev.com). The agent follows the skill template and runs gh pr create, which fails with:

none of the git remotes configured for this repository point to a known GitHub host.

The push itself succeeds — only MR creation fails.

Location

skills/finishing-a-development-branch/SKILL.md — line 128:

gh pr create --title "<title>" --body "..."

No platform detection precedes this call.

Expected behavior

Before creating a PR/MR, detect the hosting platform from the remote URL and use the appropriate tool:

Platform	Tool
github.com	gh pr create
gitlab.com or self-hosted GitLab	glab mr create
bitbucket.org	bb pr create (or REST API)
Unknown	Print the MR creation URL and ask the user to open it manually

gh can remain the default example in the skill template, but the instructions should make clear that the agent must check git remote get-url origin first and route to the right tool. If no known CLI is available for the detected platform, fall back to constructing the web URL for the user.

The Red Flags / Common Mistakes section is a good place to add:

Using gh on non-GitHub repos — Always check git remote get-url origin before creating a PR/MR. Use gh for GitHub, glab for GitLab, or fall back to the web URL if the platform is unknown.

[obra]

I think the right way for us to fix this is to remove the github-specific instruction, rather than trying to chase a table of all the code forges out there. It's very likely that every agent working on a codebase already knows how that codebase's forge tooling works.

[arittr]

Fixed on dev by #1665.

The final merged fix removes the GitHub-specific gh pr create instruction from skills/finishing-a-development-branch/SKILL.md, matching the maintainer direction above: avoid hardcoding forge-specific PR/MR creation rather than trying to maintain a table for every platform.

Closing as implemented on dev; this should ship in the next release.