Skip to content

Logging format argument - logfmt / json #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Logging format argument - logfmt / json #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ type CmdConfig struct {
ScaleTimeout time.Duration
useAzAwareHashRing bool
podAzAnnotationKey string
LogFormat string
}

func parseFlags() CmdConfig {
Expand All @@ -98,18 +99,26 @@ func parseFlags() CmdConfig {
flag.DurationVar(&config.ScaleTimeout, "scale-timeout", defaultScaleTimeout, "A timeout to wait for receivers to really start after they report healthy")
flag.BoolVar(&config.useAzAwareHashRing, "use-az-aware-hashring", false, "A boolean to use az aware hashring to comply with Thanos v0.32+")
flag.StringVar(&config.podAzAnnotationKey, "pod-az-annotation-key", "", "pod annotation key for AZ Info, If not specified or key not found, will use sts name as AZ key")
flag.StringVar(&config.LogFormat, "log.format", "logfmt", "Log format to use. Possible options: logfmt or json.")
flag.Parse()

return config
}

func main() {
logger := log.NewLogfmtLogger(log.NewSyncWriter(os.Stderr))
logger = log.WithPrefix(logger, "ts", log.DefaultTimestampUTC)
logger = log.WithPrefix(logger, "caller", log.DefaultCaller)

config := parseFlags()

var logger log.Logger
if config.LogFormat == "json" {
logger = log.NewJSONLogger(log.NewSyncWriter(os.Stderr))
logger = log.WithPrefix(logger, "ts", log.DefaultTimestampUTC)
logger = log.WithPrefix(logger, "caller", log.DefaultCaller)
} else {
logger = log.NewLogfmtLogger(log.NewSyncWriter(os.Stderr))
logger = log.WithPrefix(logger, "ts", log.DefaultTimestampUTC)
logger = log.WithPrefix(logger, "caller", log.DefaultCaller)
}

var tmpControllerLabel string
if len(config.StatefulSetLabel) > 0 {
tmpControllerLabel = config.StatefulSetLabel
Expand Down