feat: add telemetry helper utils #1346
Conversation
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
============================================
+ Coverage 92.81% 93.35% +0.53%
- Complexity 469 480 +11
============================================
Files 43 45 +2
Lines 1127 1158 +31
Branches 91 99 +8
============================================
+ Hits 1046 1081 +35
+ Misses 53 48 -5
- Partials 28 29 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| * @return an EvaluationEvent populated with telemetry data | ||
| */ | ||
| public static EvaluationEvent createEvaluationEvent( | ||
| HookContext<?> hookContext, ProviderEvaluation<?> providerEvaluation) { |
There was a problem hiding this comment.
The OTel folks requested that we make a couple of changes in the OTel semcon. Let's wait to merge this until those issues have been resolved.
https://cloud-native.slack.com/archives/C07AES1JN56/p1741799036596509
@beeme1mr can we revive this PR now? cc @liran2000 |
|
@liran2000 is there any progress on this PR or do you plan to wait for the OTel PR to be merged? I think we can proceed under the assumption that the PR will be merged as it is currently. |
Hi, waiting for @beeme1mr according to his comment. |
The semconv has changed, and some attributes have been renamed. Furthermore, the body usage is deprecated and should be part of the attributes. see: open-telemetry/semantic-conventions#1990 Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
|
Hey @liran2000, thank you for doing the heavy lifting with this pr. As the semconv has been merged, I adapted your code (renamings mainly) so we can get this merged. Thank you so much! |
aepfli
dismissed
beeme1mr’s stale review
the reason for requested changes has been lifted, the semconv is merged, and we could adapt the pull request based on it
Signed-off-by: Simon Schrottner <[email protected]>
|
This PR
adds a method to core that returns a semantically valid flag evaluation event
Related Issues
Fixes #1327
Similar to GO PR.