Skip to content

Move the evaluated value from the event body to attributes #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 12, 2025
Merged

Move the evaluated value from the event body to attributes #1990

merged 16 commits into from
May 12, 2025
+62 −35

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 12, 2025

This came as a result of @trask reviewing the feature flag semconv to move away from body fields to attributes. type is also added because the evaluated value can be any type.

@dyladan dyladan requested review from a team as code owners March 12, 2025 13:42
beeme1mr
beeme1mr reviewed Mar 12, 2025
View reviewed changes
@dyladan dyladan mentioned this pull request Mar 12, 2025
Merged
dyladan
dyladan commented Mar 13, 2025
View reviewed changes
@lmolkova lmolkova moved this from Untriaged to Awaiting SIG approval in Semantic Conventions Triage Mar 17, 2025
@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 29, 2025
@trask trask removed the Stale label Mar 29, 2025
trask
trask reviewed Apr 8, 2025
View reviewed changes
@dyladan
Copy link
Member Author

dyladan commented Apr 9, 2025

@open-telemetry/specs-semconv-maintainers there's no schema to represent this change correct? I guess in those cases there's nothing we can do?

@dyladan dyladan mentioned this pull request Apr 16, 2025
Closed
@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 27, 2025
@lmolkova lmolkova removed the Stale label Apr 27, 2025
@dyladan
Copy link
Member Author

dyladan commented May 7, 2025

@trask PR checks now passing i'd appreciate another review. Updated to have any type feature_flag.result.value

moredip
moredip reviewed May 8, 2025
View reviewed changes
moredip
moredip reviewed May 8, 2025
View reviewed changes
askpt
askpt reviewed May 9, 2025
View reviewed changes
@dyladan @moredip @askpt
Apply suggestions from code review
231fa92 
Co-authored-by: Pete Hodgson <[email protected]>
Co-authored-by: André Silva <[email protected]>
@lmolkova lmolkova moved this from Awaiting SIG approval to Needs More Approval in Semantic Conventions Triage May 12, 2025
@dyladan dyladan moved this to In Progress in SemConv: Feature Flags May 12, 2025
@dyladan dyladan mentioned this pull request May 12, 2025
Closed
lmolkova
lmolkova reviewed May 12, 2025
View reviewed changes
lmolkova
lmolkova reviewed May 12, 2025
View reviewed changes
@lmolkova lmolkova added this pull request to the merge queue May 12, 2025
Merged via the queue into open-telemetry:main with commit 5eccb6f May 12, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in SemConv: Feature Flags May 12, 2025
aepfli added a commit to liran2000/java-sdk that referenced this pull request May 13, 2025
@aepfli
fixup: apply changes according to the semconv
2d2104b 
The semconv has changed, and some attributes have been
renamed. Furthermore, the body usage is deprecated
and should be part of the attributes.

see: open-telemetry/semantic-conventions#1990
Signed-off-by: Simon Schrottner <[email protected]>
aepfli added a commit to open-feature/java-sdk that referenced this pull request May 13, 2025
@liran2000 @aepfli
feat: add telemetry helper utils (#1346)
d0ae548 
* feat: add telemetry helper utils

Signed-off-by: liran2000 <[email protected]>

* updates

Signed-off-by: liran2000 <[email protected]>

* fixup: apply changes according to the semconv

The semconv has changed, and some attributes have been
renamed. Furthermore, the body usage is deprecated
and should be part of the attributes.

see: open-telemetry/semantic-conventions#1990
Signed-off-by: Simon Schrottner <[email protected]>

* fixup: fix tests

Signed-off-by: Simon Schrottner <[email protected]>

* fixup: fix spotless

Signed-off-by: Simon Schrottner <[email protected]>

---------

Signed-off-by: liran2000 <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Co-authored-by: Simon Schrottner <[email protected]>
lmolkova pushed a commit to lmolkova/semantic-conventions that referenced this pull request May 13, 2025
@dyladan @moredip @askpt
Move the evaluated value from the event body to attributes (open-tele…
4fb2630 
…metry#1990)

Co-authored-by: Pete Hodgson <[email protected]>
Co-authored-by: André Silva <[email protected]>
This was referenced May 22, 2025
Closed
Merged
MrAlias added a commit to open-telemetry/opentelemetry-go that referenced this pull request May 23, 2025
@MrAlias
Semconv v1.34.0 (#6812)
e587b18 
Resolve #6811 
Resolve #6691

No migration documentation is added. This does not contain any breaking
changes between v1.34.0 and v1.33.0 for the Go API.

## [`v1.34.0` semantic convention release
notes](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.34.0):

<h3>🛑 Breaking changes 🛑</h3>
<ul>
<li>
<p><code>all</code>: Convert deprecated text to structured format. (<a
href="open-telemetry/semantic-conventions#2047"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2047/hovercard">#2047</a>)<br>
This is a breaking change from the schema perspective, but does not
change anything for instrumentations or the end users. It breaks
compatibility with the (old) <a
href="open-telemetry/build-tools#322"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/build-tools/issues/322/hovercard">code
generation tooling</a>. Please use <a
href="https://github.com/open-telemetry/weaver">weaver</a> to generate
Semantic Conventions markdown or code.</p>
</li>
<li>
<p><code>feature_flag</code>: Move the evaluated value from the event
body to attributes (<a
href="open-telemetry/semantic-conventions#1990"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1990/hovercard">#1990</a>)</p>
</li>
<li>
<p><code>process</code>: Require sensitive data sanitization for
<code>process.command_args</code> and <code>process.command_line</code>
(<a
href="open-telemetry/semantic-conventions#626"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/626/hovercard">#626</a>)</p>
</li>
</ul>
<h3>💡 Enhancements 💡</h3>
<ul>
<li><code>docs</code>: Document system-specific naming conventions (<a
href="open-telemetry/semantic-conventions#608"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/608/hovercard">#608</a>,
<a
href="open-telemetry/semantic-conventions#1494"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1494/hovercard">#1494</a>,
<a
href="open-telemetry/semantic-conventions#1708"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1708/hovercard">#1708</a>)</li>
<li><code>gen-ai</code>: Add <code>gen_ai.conversation.id</code>
attribute (<a
href="open-telemetry/semantic-conventions#2024"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2024/hovercard">#2024</a>)</li>
<li><code>all</code>: Renames all <code>resource.*</code> groups to be
<code>entity.*</code> (<a
href="open-telemetry/semantic-conventions#2244"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2244/hovercard">#2244</a>)<br>
Part of <a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2885075816" data-permission-text="Title is private"
data-url="open-telemetry/opentelemetry-specification#4436"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/opentelemetry-specification/issues/4436/hovercard"
href="https://github.com/open-telemetry/opentelemetry-specification/issues/4436">open-telemetry/opentelemetry-specification#4436</a></li>
<li><code>aws</code>: Added new AWS attributes for various services
including SQS, SNS, Bedrock, Step Functions, Secrets Manager and Kineses
(<a
href="open-telemetry/semantic-conventions#1794"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1794/hovercard">#1794</a>)</li>
<li><code>cloud</code>: Broaden <code>cloud.region</code> definition to
explicitly cover both resource location and targeted destination. (<a
href="open-telemetry/semantic-conventions#2142"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2142/hovercard">#2142</a>)</li>
<li><code>network</code>: Stabilize <code>network.transport</code> enum
value <code>quic</code>. (<a
href="open-telemetry/semantic-conventions#2275"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2275/hovercard">#2275</a>)</li>
</ul>
<h3>🧰 Bug fixes 🧰</h3>
<ul>
<li><code>db</code>: Fix the <code>db.system.name</code> attribute value
for MySQL which was incorrectly pointing to
<code>microsoft.sql_server</code>. (<a
href="open-telemetry/semantic-conventions#2276"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2276/hovercard">#2276</a>)</li>
</ul>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@jsuereth jsuereth jsuereth approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@lmolkova lmolkova lmolkova approved these changes

@askpt askpt askpt approved these changes

@lukas-reining lukas-reining lukas-reining approved these changes

+4 more reviewers

@moredip moredip moredip approved these changes

@jonathannorris jonathannorris jonathannorris approved these changes

@chrfwow chrfwow chrfwow approved these changes

@thomaspoignant thomaspoignant thomaspoignant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
breaking
Projects
SemConv: Feature Flags
Status: Done
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.