Skip to content

chore(agents): bump built-in adapter ranges#275

Merged
steipete merged 1 commit into
mainfrom
deps/builtin-adapters
Apr 25, 2026
Merged

chore(agents): bump built-in adapter ranges#275
steipete merged 1 commit into
mainfrom
deps/builtin-adapters

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Bumps built-in npm adapter ranges missed by the package dependency update:

  • @zed-industries/codex-acp from ^0.11.1 to ^0.12.0 (latest published 2026-04-24)
  • pi-acp from ^0.0.22 to ^0.0.26

@agentclientprotocol/claude-agent-acp and @agentclientprotocol/sdk were already current at 0.31.0 / 0.20.0.

Local proof:

  • fnm exec --using=24.15.0 corepack pnpm@10.33.2 run build:test
  • fnm exec --using=24.15.0 node --test dist-test/test/agent-registry.test.js
  • fnm exec --using=24.15.0 corepack pnpm@10.33.2 run check (573 tests)

@cursor

cursor Bot commented Apr 25, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk: only updates default npm package version ranges for built-in agent launches and adds a small test asserting the new ranges.

Overview
Updates the default built-in agent adapter package ranges so fresh launches use @zed-industries/codex-acp@^0.12.0 and pi-acp@^0.0.26.

Adds coverage in agent-registry tests to assert the registry commands and package specs reflect the bumped ranges, and documents the bump in CHANGELOG.md.

Reviewed by Cursor Bugbot for commit f99f28a. Bugbot is set up for automated code reviews on this repo. Configure here.

@steipete steipete merged commit 957c604 into main Apr 25, 2026
9 checks passed
@steipete steipete deleted the deps/builtin-adapters branch April 25, 2026 08:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f99f28a2a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md

### Changes

- Agents/built-ins: bump the default `@zed-industries/codex-acp` package range to `^0.12.0` and `pi-acp` to `^0.0.26` so fresh built-in launches pick up the latest adapter releases.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Append new Unreleased changelog item at section end

AGENTS.md requires new CHANGELOG.md entries under ## Unreleased to be appended to the end of the target section, but this bullet was inserted at the top of ### Changes. That violates the repo’s changelog ordering rule and will create unnecessary merge conflicts as additional entries are added.

Useful? React with 👍 / 👎.

Comment thread CHANGELOG.md

### Changes

- Agents/built-ins: bump the default `@zed-industries/codex-acp` package range to `^0.12.0` and `pi-acp` to `^0.0.26` so fresh built-in launches pick up the latest adapter releases.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove adapter semver ranges from changelog prose

The repo policy in AGENTS.md says documentation must not include adapter package version specifiers/semver ranges, but this line adds explicit ranges for codex-acp and pi-acp. Keeping hardcoded adapter versions in docs is explicitly disallowed here and makes documentation drift more likely; this entry should describe the update without embedding ranges.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant