Skip to content

Switch to github.com/opencontainers/cgroups #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Feb 21, 2025

This a draft pending the merge of opencontainers/cgroups#1.

This removes libcontainer/cgroups packages and starts
using those from github.com/opencontainers/cgroups repo.

Mostly generated by:

  git rm -f libcontainer/cgroups

  find . -type f -name "*.go" -exec sed -i \
    's|github.com/opencontainers/runc/libcontainer/cgroups|github.com/opencontainers/cgroups|g' \
    {} +

  go get github.com/opencontainers/[email protected]
  make vendor
  gofumpt -w .

For #4618.

@kolyshkin kolyshkin force-pushed the use-opencontainers-cgroups branch 2 times, most recently from 986f5e2 to f691f4d Compare February 21, 2025 23:06
@dims
Copy link
Contributor

dims commented Feb 21, 2025

❤️

@kolyshkin kolyshkin force-pushed the use-opencontainers-cgroups branch 3 times, most recently from 4b6c7c8 to 92e997a Compare February 26, 2025 01:36
@cyphar cyphar added this to the 1.3.0-rc.1 milestone Feb 26, 2025
@cyphar
Copy link
Member

cyphar commented Feb 28, 2025

I've merged opencontainers/cgroups#1.

Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolyshkin thanks! This looks rather trivial, after you remove the replace in the go.mod, this LGTM :)

@kolyshkin kolyshkin force-pushed the use-opencontainers-cgroups branch from 92e997a to ae28444 Compare February 28, 2025 19:07
@kolyshkin kolyshkin marked this pull request as ready for review February 28, 2025 19:10
@kolyshkin kolyshkin force-pushed the use-opencontainers-cgroups branch from ae28444 to fcb453d Compare February 28, 2025 19:18
This removes libcontainer/cgroups packages and starts
using those from github.com/opencontainers/cgroups repo.

Mostly generated by:

  git rm -f libcontainer/cgroups

  find . -type f -name "*.go" -exec sed -i \
    's|github.com/opencontainers/runc/libcontainer/cgroups|github.com/opencontainers/cgroups|g' \
    {} +

  go get github.com/opencontainers/[email protected]
  make vendor
  gofumpt -w .

Signed-off-by: Kir Kolyshkin <[email protected]>
Copy link
Member

@lifubang lifubang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's hope there will be no commits need to backport to release-1.2 in cgroups area in the future.

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lifubang We only really need to worry about that until October. After then we would only need to backport severe security issues and it seems unlikely we'll have one in the cgroup code between October and next April.

@cyphar cyphar merged commit b0a21af into opencontainers:main Mar 1, 2025
34 checks passed
winkingturtle-vmw added a commit to cloudfoundry/guardian that referenced this pull request Apr 30, 2025
from opencontainers/runc/libcontainer/cgroups

Context: opencontainers/runc#4638
winkingturtle-vmw added a commit to cloudfoundry/guardian that referenced this pull request Apr 30, 2025
from opencontainers/runc/libcontainer/cgroups

Context: opencontainers/runc#4638
ebroberson pushed a commit to cloudfoundry/guardian that referenced this pull request Apr 30, 2025
from opencontainers/runc/libcontainer/cgroups

Context: opencontainers/runc#4638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants