-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Switch to github.com/opencontainers/cgroups #4638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to github.com/opencontainers/cgroups #4638
Conversation
986f5e2
to
f691f4d
Compare
❤️ |
4b6c7c8
to
92e997a
Compare
I've merged opencontainers/cgroups#1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolyshkin thanks! This looks rather trivial, after you remove the replace in the go.mod, this LGTM :)
92e997a
to
ae28444
Compare
ae28444
to
fcb453d
Compare
This removes libcontainer/cgroups packages and starts using those from github.com/opencontainers/cgroups repo. Mostly generated by: git rm -f libcontainer/cgroups find . -type f -name "*.go" -exec sed -i \ 's|github.com/opencontainers/runc/libcontainer/cgroups|github.com/opencontainers/cgroups|g' \ {} + go get github.com/opencontainers/[email protected] make vendor gofumpt -w . Signed-off-by: Kir Kolyshkin <[email protected]>
fcb453d
to
a75076b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's hope there will be no commits need to backport to release-1.2
in cgroups area in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@lifubang We only really need to worry about that until October. After then we would only need to backport severe security issues and it seems unlikely we'll have one in the cgroup code between October and next April.
from opencontainers/runc/libcontainer/cgroups Context: opencontainers/runc#4638
from opencontainers/runc/libcontainer/cgroups Context: opencontainers/runc#4638
from opencontainers/runc/libcontainer/cgroups Context: opencontainers/runc#4638
This a draft pending the merge of opencontainers/cgroups#1.This removes libcontainer/cgroups packages and starts
using those from github.com/opencontainers/cgroups repo.
Mostly generated by:
For #4618.