libcontainer/intelrdt: add support for EnableMonitoring field #4832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquiz
force-pushed
the
devel/rdt-enablemonitoring
branch
4 times, most recently
from
520aadd to
d141fb0
Compare
rata
reviewed
Aug 5, 2025
libcontainer/intelrdt/intelrdt.go
Outdated
| if m.config.IntelRdt.ClosID == "" { | ||
| m.mu.Lock() | ||
| defer m.mu.Unlock() | ||
| if err := os.RemoveAll(m.GetPath()); err != nil { |
There was a problem hiding this comment.
RemoveAll is kind of dangerous. Can we use os.Remove() here instead?
There was a problem hiding this comment.
Check, changed as suggested. Added as a separate commit. I also submitted this commit as a separate PR #4840
libcontainer/intelrdt/intelrdt.go
Outdated
| } else if monPath := m.GetMonPath(); monPath != "" { | ||
| // If ClosID is not specified the possible monintoring group was | ||
| // removed with the CLOS above. | ||
| if err := os.RemoveAll(monPath); err != nil { |
There was a problem hiding this comment.
Changed as suggested. See also #4840
libcontainer/intelrdt/intelrdt.go
Outdated
| // monitoring group. | ||
| func (m *Manager) GetMonPath() string { | ||
| if closPath := m.GetPath(); closPath != "" && m.config.IntelRdt.EnableMonitoring { | ||
| return filepath.Join(closPath, "mon_groups", m.id) |
There was a problem hiding this comment.
Changed as suggested
libcontainer/intelrdt/intelrdt.go
Outdated
| @@ -474,6 +474,16 @@ func (m *Manager) Apply(pid int) (err error) { | |||
| return newLastCmdError(err) | |||
| } | |||
|
|
|||
| // Create MON group | |||
| if monPath := m.GetMonPath(); monPath != "" { | |||
| if err := os.MkdirAll(monPath, 0o755); err != nil { | |||
There was a problem hiding this comment.
Where is this path? Inside the container? On the host?
There was a problem hiding this comment.
This is on the host (now changed to Mkdir)
marquiz
force-pushed
the
devel/rdt-enablemonitoring
branch
3 times, most recently
from
169609d to
4024488
Compare
marquiz
force-pushed
the
devel/rdt-enablemonitoring
branch
from
4024488 to
86329fe
Compare
Signed-off-by: Markus Lehtonen <[email protected]>
marquiz
force-pushed
the
devel/rdt-enablemonitoring
branch
from
86329fe to
2380794
Compare
|
Rebased |
The linux.intelRdt.enableMonitoring field enables the creation of a per-container monitoring group. The monitoring group is removed when the container is destroyed. Signed-off-by: Markus Lehtonen <[email protected]>
marquiz
force-pushed
the
devel/rdt-enablemonitoring
branch
from
2380794 to
e31d98c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linux.intelRdt.enableMonitoring field enables the creation of a per-container monitoring group. The monitoring group is removed when the container is destroyed.
Refs: opencontainers/runtime-spec#1287