-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update busybox:glibc
in integration tests to latest builds
#4842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -10,7 +10,7 @@ set -Eeuo pipefail | |||
|
|||
images=( | |||
# pinned to an older BusyBox (prior to 1.36 becoming "latest") because 1.36.0 has some unresolved bugs, especially around sha256sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this comment is now outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch! Updated with a link to the commit history of the library/busybox
file so it's hopefully more clear where the commit hash comes from. 👍
@ricardobranco777 can you test if this fixes #4836 for you? |
Signed-off-by: Tianon Gravi <[email protected]>
Sure, thanks! |
It works for other architectures but continues failing on ppc64le: https://openqa.opensuse.org/tests/5228054 The coredump is available at https://openqa.opensuse.org/tests/5228054/file/runc-unshare.44911.core.gz I notice other coredumps for mkdir in https://openqa.opensuse.org/tests/5228054#downloads |
https://openqa.opensuse.org/tests/5228054/file/runc-coredumpctl.txt Weird that mkdir was killed with SIGSYS but this is not exclusive to ppc64le.
The mkdir part is not exclusive to ppc64le but also seen on x86_64: |
This comment was marked as outdated.
This comment was marked as outdated.
Again, this is part of test. We check that seccomp we specify in spec is properly applied, and use mkdir. Here's the test: runc/tests/integration/seccomp.bats Lines 155 to 166 in 89c46a9
|
In this case, seccomp acts as if the program got SIGSYS. |
Of course. Now it makes sense! Thanks. |
@ricardobranco777 I see no other way as to build busybox's unshare with debug info on and run it in your environment, instead of a bundled |
Thanks for the suggestion. I'll try this on Monday. |
tests/integration/get-images.sh
Outdated
# https://github.com/docker-library/busybox/tree/9ca13bc214717966383cf97e08606b444b7300e4/stable/glibc | ||
url="https://github.com/docker-library/busybox/raw/9ca13bc214717966383cf97e08606b444b7300e4/stable/glibc/busybox.tar.xz" | ||
# https://github.com/docker-library/busybox/tree/3bbb15b7efd6d99a73690516b4499b6642f97ef5/latest/glibc/ppc64le | ||
url="https://github.com/docker-library/busybox/raw/3bbb15b7efd6d99a73690516b4499b6642f97ef5/latest/glibc/ppc64le/rootfs.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've hacked up a build of this with busybox_unstripped
so that it hopefully contains debug symbols (and thus will hopefully generate a more useful/helpful core dump):
url="https://github.com/docker-library/busybox/raw/3bbb15b7efd6d99a73690516b4499b6642f97ef5/latest/glibc/ppc64le/rootfs.tar.gz" | |
url="https://github.com/docker-library/busybox/raw/83c2287084a6f001a67d97fdfa23497c75520f2a/latest/glibc/ppc64le/rootfs.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also commit this with a DNM:
commit to this PR if you need me to in order to feed it into your OpenQA system; just let me know 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also commit this with a
DNM:
commit to this PR if you need me to in order to feed it into your OpenQA system; just let me know 👍
Cool, let's try this.
Ok, PR updated (temporarily) with a new commit that switches |
Here is the generated core: https://openqa.opensuse.org/tests/5231369/file/runc-core.unshare.45076.core.xz Unfortunately, the glibc libraries are stripped on the rootfs. Thanks! |
With this, I got:
I'm puzzled as to why unshare calls waitpid. |
The repo structure changed a little, but it was trivial enough to adapt to (given I knew exactly where to point the hammer 😂 ❤️). 👍
@kolyshkin want to give this a try? I know you said 1.35.1, but I went all the way to 1.37.0 because it's worth trying latest instead first, right? (Worst case I update and walk it back again 😅)