Skip to content

Added Cypress QS specific versioning #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

roicarrera
Copy link
Contributor

Included versioning specific to the cypress quickstarter in the package.json and pinned dependencies versions

@cschweikert
Copy link
Member

Hi @garcanam, I would not recommend pinning versions here. It should be fine to allow minor version updates. With pinning there is a certain risk that a quickstarter gets provisioned with known security issues. It would also require us to keep track of those issues to quickly react with updates to the quickstarter, which again will take its time.

To pin versions for reproducible tests you should have a package-lock.json in your repo anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants