This repository was archived by the owner on Mar 10, 2023. It is now read-only.
Don't error if ECR Repository exists already #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were returning an error if the ECR repo already exists. This shouldnt give an error because it's not a failure. If the repo doesn't exist then we create it, if it exists then that's fine. Tested by deploying an ECR backed OFC installation, first time round it creates the new repo, then after that it's not throwing an error, only saying it already exists. Signed-off-by: Alistair Hey <[email protected]>
|
Thanks for the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were returning an error if the ECR repo already exists. This shouldnt
give an error because it's not a failure. If the repo doesn't exist then
we create it, if it exists then that's fine.
Fixes #539
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
Tested by deploying an ECR backed OFC installation, first time round it
creates the new repo, then after that it's not throwing an error, only
saying it already exists.
After - when trying to create repo that exists
How are existing users impacted? What migration steps/scripts do we need?
New deployment of register-image required. This fixes some output not to return an error.
Checklist:
I have:
git commit -s