This repository was archived by the owner on Mar 10, 2023. It is now read-only.
Upgrade derek dependency to 0.10.2 #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonianb
suggested changes
Sep 17, 2020
There was a problem hiding this comment.
I'm getting the following error in github-status:
Invalid Key: Key must be PEM encoded PKCS1 or PKCS8 private key
It goes away if I update the call to MakeAccessTokenForInstallation (see below), and I no longer get the email warning about my new GitHub app calling the deprecated endpoint 🎉
github-status/vendor/github.com/alexellis/derek/auth/jwt_auth.go
Outdated
Show resolved
Hide resolved
Waterdrips
force-pushed
the
waterdrips-upgrade-derek
branch
2 times, most recently
from
d284fcf to
01fe28c
Compare
|
Good spots, updated to 10.2. and made changes & fixes based on suggestions, fancy giving this branch a build and try @wilsonianb |
alexellis
reviewed
Sep 17, 2020
alexellis
reviewed
Sep 17, 2020
alexellis
reviewed
Sep 17, 2020
Waterdrips
force-pushed
the
waterdrips-upgrade-derek
branch
from
01fe28c to
ae6ca5c
Compare
This version of derek includes an update to remove a soon to be depricated API endpoint on github. Reference: https://developer.github.com/changes/2020-04-15-replacing-create-installation-access-token-endpoint/ Signed-off-by: Alistair Hey <[email protected]>
Waterdrips
force-pushed
the
waterdrips-upgrade-derek
branch
from
ae6ca5c to
cf722c7
Compare
wilsonianb
reviewed
Sep 17, 2020
| @@ -119,14 +125,31 @@ func getLogs(status *sdk.CommitStatus, event *sdk.Event) (string, error) { | |||
| } | |||
|
|
|||
| func reportToGithub(commitStatus *sdk.CommitStatus, event *sdk.Event) error { | |||
| secretKey, err := sdk.ReadSecret(defaultPayloadSecretName) | |||
| if err != nil { | |||
| log.Printf("reusing provided auth token") | |||
There was a problem hiding this comment.
seems like this can be removed
wilsonianb
reviewed
Sep 17, 2020
|
@wilsonianb thanks for your input here. PRs are welcome - you seem to have a good handle on how things fit together. Try to keep them short & sweet. Ideally defensible - i.e. changes for a defined purpose. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alistair Hey [email protected]
Description
This version of derek includes an update to remove a soon to be depricated API endpoint on github.
Reference: https://developer.github.com/changes/2020-04-15-replacing-create-installation-access-token-endpoint/
This release will need the following 3 containers bumped:
note: buildshiprun wasnt using Derek for auth but had it in the Gopkg
How Has This Been Tested?
A new OFC installation was created and the above 3x containers swapped for my own built versions.
A deployment was then completed using a commit from a linked git repository.
How are existing users impacted? What migration steps/scripts do we need?
Github users will need to update these 3x containers in their installations before the endpoint on github is deprecated.
Checklist:
I have:
git commit -s