This repository was archived by the owner on Mar 10, 2023. It is now read-only.
Remove of-client-secret as env var from edge-auth #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edge-auth now only uses the mounted secret to read the of-client-secret for Oauth2. This is to reduce complexity in the chart and deployments. Signed-off-by: Alistair Hey <[email protected]>
|
There's a couple stray |
|
apologies - fixed now based on your commit 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edge-auth now only uses the mounted secret to read the of-client-secret
for Oauth2. This is to reduce complexity in the chart and deployments.
Signed-off-by: Alistair Hey [email protected]
Fixes #673
How Has This Been Tested?
the golang chart tests pass. This functionality has been in use for a long time, iv not seen the env variable being used over the secret anywhere.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
git commit -s