This repository was archived by the owner on Mar 10, 2023. It is now read-only.
Remove redundant setting for scheme in chart #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chart had a setting that can be derived based on another value. This commit removed the extra config value as it is not required Signed-off-by: Alistair Hey <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chart had a setting that can be derived based on another value. This
commit removed the extra config value as it is not required
Signed-off-by: Alistair Hey [email protected]
Description
Fixes #677
How Has This Been Tested?
There's unit tests
How are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I have:
git commit -s