This repository was archived by the owner on Mar 10, 2023. It is now read-only.
Remove a print of customers in edge-auth #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
reviewed
Nov 8, 2020
edge-auth/handlers/query.go
Outdated
| @@ -30,7 +30,10 @@ func MakeQueryHandler(config *Config, protected []string, restrictedPrefix []str | |||
| customersURL := os.Getenv("customers_url") | |||
|
|
|||
| customers := sdk.NewCustomers(customersPath, customersURL) | |||
| customers.Fetch() | |||
| if err := customers.Fetch(); err != nil { | |||
| log.Fatalf("Unable to fetch customers from configured source") | |||
There was a problem hiding this comment.
Not sure if this should be fatal. What if it timed out?
There was a problem hiding this comment.
then the next time they try it might not? changed the log line and written a 500 internal server error instead.
This removes a printing of the customers in edge-auth. Signed-off-by: Alistair Hey <[email protected]>
Waterdrips
force-pushed
the
waterdrips-remove-logline
branch
from
d1f696a to
59cc912
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes a printing of the customers in edge-auth.
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
reduced log noise
Checklist:
I have:
git commit -s