-
Notifications
You must be signed in to change notification settings - Fork 28
chore: use priority ordering in java repo finder #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
28c0858
to
f98d2d0
Compare
787062d
to
38d9537
Compare
I have tested your implementation and it seems that because calling tags = defaults.get_list("repofinder.java", "repo_pom_paths", duplicated_ok=True) At this place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. LGTM (given the assumption that the issue discussed in #641 (comment) is going to be addressed in a separated PR).
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
3dab90b
to
8f7d2d8
Compare
Yes, agreed. @tromai can you please work on this issue in a separate PR? |
Signed-off-by: Ben Selwyn-Smith <[email protected]>
This PR makes the configuration property
repo_pom_paths
a priority list. When the Repo Finder is resolving URLs to repositories, the first valid URL (based on the ordering of therepo_pom_paths
) will be returned. By default, the highest priority SCM entry in a POM should beurl
, as this most reliably represents the URL of the source repository.Closes #640