generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 28
feat: add checks to determine if repo and commit came from provenance #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@benmss The scope of this PR should be |
ceb45be
to
a7b2a2a
Compare
cdec8f2
to
dbfd995
Compare
nicallen
reviewed
May 8, 2024
nicallen
reviewed
May 8, 2024
behnazh-w
reviewed
May 8, 2024
tromai
reviewed
May 9, 2024
tromai
reviewed
May 9, 2024
tromai
reviewed
May 9, 2024
e5a567a
to
af35243
Compare
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
af35243
to
1279beb
Compare
tromai
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. LGTM.
behnazh-w
reviewed
May 14, 2024
behnazh-w
reviewed
May 14, 2024
@benmss Please update the list of checks in |
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
behnazh-w
reviewed
May 15, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
behnazh-w
approved these changes
May 15, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
…#704) This PR adds two new checks that succeed if the repository URL or commit of the analysis target match those that can be extracted from the provenance, respectively. If the repository or provenance do not exist, or do not contain the needed information, or are not identical, these checks will fail. Signed-off-by: Ben Selwyn-Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new check that succeeds if the repository URL and commit of the analysis target match those that can be extracted from the provenance. If the repository or provenance do not exist, or do not contain the needed information, or are not identical, this check will fail.
Closes #677