fix: do not fetch from origin/HEAD for local repo targets #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: behnazh-w <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: behnazh-w <[email protected]>
behnazh-w
force-pushed
the
behnazh/fix-local-repo
branch
from
6be72eb to
4fc565f
Compare
tromai
reviewed
May 13, 2024
tromai
reviewed
May 14, 2024
Signed-off-by: behnazh-w <[email protected]>
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
For analyzing local repositories in offline mode, we should not fetch from origin/HEAD because user might want to run Macaron on the local changes. This PR changes the check_out_repo_target function to fix this issue: if branch_name and a commit are not provided, this function will not do anything and the HEAD commit will be analyzed. If there are uncommitted local changes, the HEAD commit will appear in the report but the repo with local changes will be analyzed. We leave it up to the user to decide whether to commit the changes or not. Signed-off-by: behnazh-w <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For analyzing local repositories in offline mode, we should not fetch from
origin/HEADbecause user might want to run Macaron on the local changes. This PR changes thecheck_out_repo_targetfunction to fix this issue: ifbranch_nameand a commit are not provided, this function will not do anything and the latest local commit will be analyzed. If there are uncommitted local changes, the latest commit will appear in the report but the repo with local changes will be analyzed. We leave it up to the user to decide whether to commit the changes or not.