Skip to content

feat: add a script to check VSA #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 16, 2024
Merged

feat: add a script to check VSA #858

merged 6 commits into from
Sep 16, 2024

Conversation

behnazh-w
Copy link
Member

@behnazh-w behnazh-w commented Sep 11, 2024

This PR adds the check_vsa.sh script, which takes an artifact, VSA, and the package URL as the artifact identifier and reports whether the verification result has been successful.

This PR also adds a tutorial for the VSAs published for the Graal Development Kit (GDK) artifacts. The Oracle Maven URLs are not accessible yet and will be working once GDK is released.

The integration test checks [email protected] with a manually generated VSA as well as [email protected] whose VSA is published on Oracle Maven.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 11, 2024
@behnazh-w behnazh-w force-pushed the behnazh/gdk-tutorial branch 3 times, most recently from e22889d to 3335a6f Compare September 11, 2024 13:13
@behnazh-w behnazh-w marked this pull request as ready for review September 12, 2024 05:06
@behnazh-w behnazh-w requested a review from tromai as a code owner September 12, 2024 05:06
Copy link
Member

@tromai tromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I have added some comments/ change requests.

Copy link
Member

@tromai tromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@behnazh-w behnazh-w requested a review from tromai September 13, 2024 06:25
@behnazh-w behnazh-w merged commit 95453c8 into staging Sep 16, 2024
11 checks passed
@behnazh-w behnazh-w deleted the behnazh/gdk-tutorial branch September 23, 2024 03:56
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
This PR adds the check_vsa.sh script, which takes an artifact, VSA, and the package URL as the artifact identifier and reports whether the verification result has been successful.

This PR also adds a tutorial for the VSAs published for the Graal Development Kit (GDK) artifacts.

The integration test checks [email protected] with a manually generated VSA as well as [email protected] whose VSA is published on Oracle Maven.

Signed-off-by: behnazh-w <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants