-
Notifications
You must be signed in to change notification settings - Fork 990
Open
Description
Extracted from: https://github.com/paritytech/polkadot-sdk/actions/runs/17068426540/job/48391174874
TRY 2 FAIL [ 0.494s] pallet-revive-eth-rpc tests::runtime_api_dry_run_addr_works
stdout ───
running 1 test
stderr ───
====================
Version: 3.0.0-dev-5e576ae2da2
0: sp_panic_handler::set::{{closure}}
1: std::panicking::rust_panic_with_hook
2: std::panicking::begin_panic_handler::{{closure}}
3: std::sys::backtrace::__rust_end_short_backtrace
4: __rustc::rust_begin_unwind
5: core::panicking::panic_fmt
6: std::sys::backtrace::__rust_begin_short_backtrace
7: core::ops::function::FnOnce::call_once{{vtable.shim}}
8: std::sys::pal::unix::thread::Thread::new::thread_start
9: start_thread
10: clone
Thread '<unnamed>' panicked at 'eth-rpc exited with error: Metadata error: Pallet with name Revive not found
Caused by:
Pallet with name Revive not found
Detected by: #9418
I believe the issue might stem from the hardcoded ports used to start the revive node and RPC:
polkadot-sdk/substrate/frame/revive/rpc/src/tests.rs
Lines 78 to 79 in 1fd25cd
"--rpc-port=45788", | |
"--node-rpc-url=ws://localhost:45789", |
Instead, we should let the node pick a valid port and extract the port from the logs similarly to subxt:
https://github.com/paritytech/subxt/blob/56cfacdb6f89a85c213ed2df70ac3e56a79906aa/testing/substrate-runner/src/lib.rs#L260-L280. Then the client should be using the said port.
cc @pgherveou
Metadata
Metadata
Assignees
Labels
No labels