feat(editor): preset placement polish — params, move tool, shadows, isolation#357
Merged
Conversation
- wall/slab/ceiling/roof create paths consume `toolDefaults` so template presets build with their saved params; cleared on tool unmount - wall draw preview reflects the preset's height/thickness (+ HUD labels) - box-select picks up registry-selectable kinds (shelf) via bbox - registry + column move tools: snap to the active grid step, R/T rotation, and ignore the stray trailing click that armed the move (no double-place) - shelf geometry casts + receives shadows like fence/slab Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Tracks whether an isolation filter is currently applied and exposes it so hosts can avoid acting on the partial view — e.g. skipping project-thumbnail autosave while a single subtree is isolated (preset capture). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Polish pass on the preset-system placement flow (consumed by
apps/communityinpascalorg/private-editorvia a submodule bump). Six related changes:wall/slab/ceiling/roofcreate paths now mergetoolDefaults[kind]so a placed template preset builds with its saved parametrics (thickness, height, materials, pitch, roofType, …) instead of the raw default. Each tool clears its entry on unmount, matching the existingfencebehaviour.selectablekinds (shelf, and future furnish/structure kinds) via their rendered bbox — they were missing from the hardcoded type list.MoveRegistryNodeTool+ column's move tool): snap to the active grid step instead of a hardcoded 0.5; R/T rotate the dragged node in 90° steps (committed on drop); and ignore a commit click that fires before the cursor has moved, which stops a preset re-arm from auto-placing a second copy from the same physical click.isIsolationActive()exported from@pascal-app/viewer: the isolation module tracks whether a subtree filter is applied, so hosts can avoid acting on the partial view (the community uses it to skip project-thumbnail autosave during preset capture).How to test
bun dev, open a scene.toolDefaults.wall): activate the wall tool with non-default thickness/height — the draft preview and the built wall both use those values.<Viewer isolate>/setIsolated,isIsolationActive()returnstrue; clearing isolation returnsfalse.Screenshots / screen recording
N/A — behavioural/rendering changes; verified via the consuming community app. A clip can be added if useful.
Checklist
bun devbun checkto verify)mainbranch