Skip to content

Adding pure Java support of V2 Local token types #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

bdemers
Copy link
Contributor

@bdemers bdemers commented Dec 11, 2020

  • Support for libsodium may be removed in the future
  • Updated README to mention v2.local support with the Bouncy Castle module

Refactored ITs, instead of running the ITs once, they now run as part of of the individual module builds

  • This ensure the ITs are run for each module (instead of just the first one on the classpath)
  • The shared tests are now fall under main/src/groovy so they can be included and run from the other modules.

@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #12 (d3c3cb1) into main (7cb92c0) will increase coverage by 0.50%.
The diff coverage is 93.02%.

❗ Current head d3c3cb1 differs from pull request most recent head 6c14669. Consider uploading reports for the commit 6c14669 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main      #12      +/-   ##
============================================
+ Coverage     83.89%   84.39%   +0.50%     
- Complexity      265      285      +20     
============================================
  Files            56       58       +2     
  Lines           770      846      +76     
  Branches         55       55              
============================================
+ Hits            646      714      +68     
- Misses           94      101       +7     
- Partials         30       31       +1     
Impacted Files Coverage Δ
...eto/crypto/sodium/SodiumV2LocalCryptoProvider.java 100.00% <ø> (ø)
...ouncycastle/BouncyCastleV2LocalCryptoProvider.java 91.30% <91.30%> (ø)
...jpaseto/crypto/bouncycastle/XChaCha20Poly1305.java 93.65% <93.65%> (ø)
...o/crypto/bouncycastle/BouncyCastleInitializer.java 50.00% <0.00%> (-50.00%) ⬇️
...jpaseto/impl/crypto/JcaV1PublicCryptoProvider.java 71.42% <0.00%> (-7.15%) ⬇️
...paseto/jpaseto/io/jackson/JacksonDeserializer.java 96.42% <0.00%> (-0.24%) ⬇️
...v/paseto/jpaseto/io/jackson/JacksonSerializer.java 100.00% <0.00%> (ø)
...va/dev/paseto/jpaseto/PasetoSecurityException.java 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb92c0...6c14669. Read the comment docs.

@bwoods8
Copy link

bwoods8 commented Apr 10, 2021

Is this till underway?

@bdemers
Copy link
Contributor Author

bdemers commented Apr 11, 2021

@bwoods8 yup! I’ll take another look at it on Monday. If you want, try out the brand and give us feed back!

@bdemers
Copy link
Contributor Author

bdemers commented Apr 12, 2021

Rebased (and squashed)

@bdemers bdemers changed the base branch from master to main April 12, 2021 16:18
@bwoods8
Copy link

bwoods8 commented Apr 15, 2021

Looks good and worked like a charm! Thanks! 😄

@bwoods8
Copy link

bwoods8 commented Sep 28, 2021

Is this still in the works? 😄

@bdemers
Copy link
Contributor Author

bdemers commented Sep 28, 2021

Yes! thanks for the bump! I'll rebase the PR and get it moving!

@bdemers bdemers changed the base branch from main to it-module September 28, 2021 18:23
Base automatically changed from it-module to main September 28, 2021 19:51
* Support for libsodium may be removed in the future
* Updated README to mention v2.local support with the Bouncy Castle module
* Refactored ITs, instead of running the ITs once, they now run as part of of the individual module builds
  - This ensure the ITs are run for each module (instead of just the first one on the classpath)
  - The shared tests are now fall under `main/src/groovy` so they can be included and run from the other modules.
@bdemers bdemers merged commit 70210c5 into main Oct 1, 2021
@bdemers bdemers deleted the bc-v2-local branch October 1, 2021 14:30
@bdemers
Copy link
Contributor Author

bdemers commented Oct 1, 2021

@bwoods8 in and released 0.7.0, it should hit Maven Central within a couple hours

@bwoods8
Copy link

bwoods8 commented Oct 1, 2021

That's great news for the weekend! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants