Fix inline key changes leaking between voices#1150
Open
Juemuren wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1109
Description
Inline
[K:]changes were being stored only in the shared parser key state. When parsing switched from one voice to another, a key change from the previous voice could leak into the next voice’s initial staff key.This change stores the running key per voice and restores it when switching voices. New voices still start from the global key, while existing voices resume from their own last key state.
Testing
V:2starting in EDor afterV:1changes inline to C.npm run build:basiclocally for syntax/build validation.