Skip to content

Exiting if invalid streaming content #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

skoky
Copy link

@skoky skoky commented Mar 25, 2025

I had to fork Symphonia and do a small change in the mpeg decoder. I am using this with https://crates.io/crates/stream-download crate. This is using Rodio and Symphonia to decode radio stream. But I am getting the invalid mpeg audio header warning from time to time. The streamed radio is not playing and I can't detect this erorr to restart the stream. I need o have the error propagated back to Rodio and streaming-donload stream to have it restarted. Wiht this fix it works fine in my fork. Can you include similar fir in next version please?

The fix is related to the #325 If you made some autodotection improvements in 0.6-dev branch its even better, but returning the errro is really necessary to handle the streaming restart. Thanks

@pdeljanov
Copy link
Owner

Sorry, this is not an appropriate fix. The reason why this case does not return an error is because if the stream is broken/corrupt Symphonia should re-synchronize to the next valid MPEG frame and then continue.

First, please test the radio stream with the symphonia-play test application: curl -s https://radio.station.com/stream | symphonia-play -.

I'm going to close this PR, but if you find that the issue reproduces with the test application, please feel free to open an issue.

@pdeljanov pdeljanov closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants