Cleanup Cargo.tomls and licenses (master branch) #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes it so that the MPl-2.0 license is bundled with each crate (as is best practice for license files). However, cargo does NOT currently have a better solution than copying the license to each crate's folder (see discussion here: rust-lang/cargo#13328), so this patch copies the LICENSE file to each crate's folder. This patch also consolidates a lot of the package metadata into the root Cargo.toml.
baylesj
changed the title
hasezoey
reviewed
Jul 24, 2025
| categories = ["multimedia", "multimedia::audio", "multimedia::encoding"] | ||
| keywords = ["audio", "codec", "decoder", "multimedia", "media"] | ||
| edition = "2018" | ||
| rust-version = "1.53" |
There was a problem hiding this comment.
FYI to my knowledge the workspace.package syntax required Rust version 1.64 or higher according to The Cargo Book: Workspaces
pdeljanov
requested changes
Aug 19, 2025
There was a problem hiding this comment.
As mentioned by @hasezoey in the comments, the workspace syntax is only supported on Rust 1.64+ and the MSRV for the 0.5.x series is 1.53. Since we consider increasing the MSRV a semver-breaking change, we cannot use that syntax in master at this time. Therefore, I think this PR can only add the LICENSE files to each crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it so that the MPl-2.0 license is bundled with each crate (as is best practice for license files). However, cargo does NOT currently have a better solution than copying the license to each crate's folder (see discussion here:
rust-lang/cargo#13328), so this patch copies the LICENSE file to each crate's folder.
This patch also consolidates a lot of the package metadata into the root Cargo.toml.
resolves #391