Skip to content

Added ability to infer JSON column type into db_create.py and added t… #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

muhammadbadar1998
Copy link
Contributor

This pull request adds inference of JSON columns from Python dict/list data, mapping them to sqlalchemy..JSON in db_create.py.

It also includes two new tests:

  • test_int_column.py for integer
  • test_json_column.py for JSON

All existing tests pass.

Closes #644

…est for int (test_int_column) and test for json (test_json_column)
@coveralls
Copy link

coveralls commented Jun 29, 2025

Pull Request Test Coverage Report for Build 15960063405

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 91.119%

Totals Coverage Status
Change from base Build 14799836363: 0.009%
Covered Lines: 13400
Relevant Lines: 14706

💛 - Coveralls

@juarezr juarezr self-requested a review June 30, 2025 18:53
@juarezr juarezr added the Feature A nice to have thing that we don't have yet label Jun 30, 2025
@juarezr juarezr merged commit 7d39289 into petl-developers:master Jun 30, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A nice to have thing that we don't have yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function make_sqlalchemy_column in db_create.py not support JSON field
3 participants