Skip to content

Closes #121 add better error message in create_adams_data.R #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 19, 2025

Conversation

Fanny-Gautier
Copy link
Collaborator

@Fanny-Gautier Fanny-Gautier commented Aug 12, 2025

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build pharmaverseadam site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new datasets occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@Fanny-Gautier
Copy link
Collaborator Author

Do we need cli in the Suggests section of the DESCRIPTION file, or is the fallback sufficient?

@shajoezhu
Copy link
Collaborator

waiting for reverse dependency check at https://github.com/pharmaverse/pharmaverseadam/actions/runs/16909071412

@shajoezhu
Copy link
Collaborator

downstream reverse depenency checks ok, I guess you have not updated the cached data?

@Fanny-Gautier
Copy link
Collaborator Author

downstream reverse depenency checks ok, I guess you have not updated the cached data?

No, the cache data haven’t been updated in this PR. This is only a code update to properly display any errors.

@Fanny-Gautier Fanny-Gautier merged commit 7b375bb into main Aug 19, 2025
16 checks passed
@Fanny-Gautier Fanny-Gautier deleted the 121_error_message_create_adams_data branch August 19, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: provide better Error message for create_adams_data.R
3 participants