Skip to content

Fix sneaking hitbox height #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: stable
Choose a base branch
from
Open

Fix sneaking hitbox height #6771

wants to merge 4 commits into from

Conversation

Dasciam
Copy link

@Dasciam Dasciam commented Aug 22, 2025

BDS sends 1.49, so 53/64 (0.828125) gonna be good for it. Reference: df-mc/dragonfly#1000

Related issues & PRs

Tests

Video_2025-08-22_12-19-06.mp4

BDS sends 1.49, so 53/64 (0.828125) gonna be good for it. 
Reference: df-mc/dragonfly#1000
@Dasciam Dasciam requested a review from a team as a code owner August 22, 2025 09:22
@dktapps
Copy link
Member

dktapps commented Aug 22, 2025

This logic seems sketchy to me, not sure who implemented it like that. In particular the eye height being scaled doesn't seem right since it'll mean the eyes are closer to the top when sneaking than when standing.

@dktapps
Copy link
Member

dktapps commented Aug 22, 2025

Also if, say, an enderman were to sneak, it'd probably change the height by a different amount than a regular biped, since an enderman is more leggy than other mobs.

Perhaps a better way to deal with this would be to have a sneak height offset (defaulting to 1.8 - 1.49) and then allow entities to override it as needed.

@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Aug 22, 2025
@Dasciam
Copy link
Author

Dasciam commented Aug 22, 2025

I think the Human is one and only entity that can sneak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants