Rearrange functions in MatterBaseTest #39858
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asirko-soft
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the MatterBaseTest class, improving readability and maintainability by organizing methods and adding docstrings. I've identified and suggested fixes for a few issues, including a potential for incorrect behavior and edge cases in test step handling.
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
|
PR #39858: Size comparison from 39de093 to 99b5bd8 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39858: Size comparison from ce90b61 to 16eaf47 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
juandediosg
reviewed
Jul 8, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
This reverts commit 832f7ea.
juandediosg
approved these changes
Jul 11, 2025
cecille
reviewed
Jul 18, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
Co-authored-by: C Freeman <[email protected]>
|
PR #39858: Size comparison from bcb9403 to 0c8664e Full report (12 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
Updated variable names from app_pipe to pipe_name for consistency across MatterBaseTest and runner.py. Adjusted error handling to reflect the new naming convention, ensuring clarity in logging and exception messages.
|
PR #39858: Size comparison from bcb9403 to 3cb3e9a Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the functions in the MatterBaseTest class according to their functionality, improving code structure and maintainability. The reorganization groups related methods into logical sections with improved docstrings for better developer understanding.
- Functions are reorganized into logical sections: Framework Interface, Core Properties, Parameter Getters, Test Definition Helpers, Step Management, Guard/Condition Helpers, Device Interaction, and Utility Helpers
- Enhanced docstrings provide clearer descriptions of method purposes and usage patterns
- No functional changes to existing code logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/python_testing/matter_testing_infrastructure/matter/testing/matter_testing.py
Show resolved
Hide resolved
|
PR #39858: Size comparison from 33f7738 to c5969e8 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39858 +/- ##
==========================================
- Coverage 50.72% 50.72% -0.01%
==========================================
Files 1356 1356
Lines 99345 99345
Branches 12876 12876
==========================================
- Hits 50397 50396 -1
- Misses 48948 48949 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 ⛓️ Depends-On RequirementsWonderful, this rule succeeded.Requirement based on the presence of
|
|
PR #39858: Size comparison from 233d3f7 to bd4f78b Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #39858: Size comparison from f1631b6 to 8f10fc7 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is just rearrangement of functions from MatterBaseTest according to their functionality. Relevant docstrings were improved as well.
Related issues
Resolves project-chip/matter-test-scripts#597
Depends-On: #39586
Testing
CI and local testing