Commodity Metering cluster test scripts update: TC_COMMTR_2_1 and TC_COMMTR_3_1 #40486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the test scripts TC_COMMTR_2_1 and TC_COMMTR_3_1 for the Commodity Metering cluster. The review identified several copy-paste errors in comments in TC_COMMTR_3_1.py. Additionally, time.sleep() is used in TC_COMMTR_TestBase.py within async functions, which blocks the event loop and should be replaced with await asyncio.sleep().
|
PR #40486: Size comparison from 17b6939 to 790a9f4 Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40486 +/- ##
==========================================
- Coverage 50.72% 50.72% -0.01%
==========================================
Files 1356 1356
Lines 99345 99345
Branches 12876 12876
==========================================
- Hits 50397 50396 -1
- Misses 48948 48949 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
PR #40486: Size comparison from 17b6939 to 8e7bd7c Increases above 0.2%:
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #40486: Size comparison from 6e50acf to 6f2e191 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #40486: Size comparison from 6e50acf to d88b2f6 Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
PR #40486: Size comparison from 6e50acf to edcfb95 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
r-recchia
reviewed
Aug 20, 2025
…bute(), add some comments
|
PR #40486: Size comparison from 6e50acf to f1b9421 Full report (3 builds for nrfconnect, qpg)
|
|
The CI is failing and it was addressed in this PR |
r-recchia
approved these changes
Aug 21, 2025
|
PR #40486: Size comparison from f1631b6 to 13a8d1d Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test scripts
TC_COMMTR_2_1andTC_COMMTR_3_1for Commodity Metering Cluster based on Test Plan update: https://github.com/CHIP-Specifications/chip-test-plans/pull/5424Testing
How to test:
Start energy-gateway-app:
Run test: