Follow-up for Camera TLS Certificate Management Cluster to bring it up to latest spec #40552
+641
−589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TLS Certificate Management Cluster to align with the latest specification. The changes are propagated from the cluster definition files (.matter and .xml) to the generated code across various languages (C++, Java, Kotlin, Objective-C, and Python). Key modifications include removing a StatusCodeEnum, renaming and resizing fields in CSR-related commands, and altering the structure of the ProvisionClientCertificateRequest. The changes are consistent across all affected files and appear to correctly implement the spec update. Based on the provided diffs, the changes look good.
|
PR #40552: Size comparison from d5106c0 to 90b9cdd Full report (26 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, qpg, stm32, telink)
|
samadDotDev
reviewed
Aug 12, 2025
samadDotDev
reviewed
Aug 12, 2025
There was a problem hiding this comment.
Might also need to re-run codegen after the merge of #40549 so that these changes are reflected in the camera app as well - I'm not sure if CI or other conflicts would enforce that update otherwise.
separate PR (not follow-up, parallel) - the PRs get big enough on their own, & splitting it on the cluster boundary is a good way to parallelize without making big PRs 😅🤣 |
gmarcosb
force-pushed
the
camera-tls-cert
branch
from
90b9cdd to
66320d1
Compare
|
PR #40552: Size comparison from 8283cdb to 66320d1 Full report (5 builds for cc32xx, realtek, stm32)
|
gmarcosb
force-pushed
the
camera-tls-cert
branch
from
66320d1 to
15daa98
Compare
|
PR #40552: Size comparison from 233d3f7 to 15daa98 Full report (4 builds for cc32xx, realtek)
|
….. TLSCertificateManagement.adoc
gmarcosb
force-pushed
the
camera-tls-cert
branch
from
15daa98 to
db3a54c
Compare
gmarcosb
force-pushed
the
camera-tls-cert
branch
from
db3a54c to
4ad005d
Compare
|
PR #40552: Size comparison from e086a20 to 4ad005d Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #40552 +/- ##
=======================================
Coverage 50.72% 50.73%
=======================================
Files 1356 1356
Lines 99337 99334 -3
Branches 12876 12871 -5
=======================================
+ Hits 50390 50397 +7
+ Misses 48947 48937 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #39754:
Related issues
Fixes #40507
Testing
CI