Fix AdministratorFabricIndex Max value allowed #40179 #40688
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
PR #40688: Size comparison from a2a07d4 to f1b6f71 Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #40688: Size comparison from a2a07d4 to 7b5fc5e Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #40688: Size comparison from 233d3f7 to 0abe0c7 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40688 +/- ##
=======================================
Coverage 50.78% 50.78%
=======================================
Files 1358 1358
Lines 99477 99477
Branches 12877 12877
=======================================
Hits 50521 50521
Misses 48956 48956 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nnectedhomeip into fix_adminindex_from_15_te1
|
PR #40688: Size comparison from 233d3f7 to b406b3e Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #40688: Size comparison from 233d3f7 to 4d764f7 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #40688: Size comparison from 71aed77 to 6d52c4c Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test script currently allows AdministratorFabricIndex = 255, but this is not spec-compliant.
Related issues
Fix: #40179
Testing
Local and CI