Add passcode display length field to UDC messages #40696
+224
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdecenzo
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a passcodeLength field to the CommissionerDeclaration in User-Directed Commissioning. While the field and its accessors are added to the header file, the implementation for serializing and deserializing this new field in WritePayload and ReadPayload respectively appears to be missing from this pull request. Without these changes, the new field will not be correctly communicated.
My review includes suggestions to use a standard integer type instead of the non-standard uint4_t for better portability and to fix a minor typo in a log message.
src/protocols/user_directed_commissioning/UserDirectedCommissioning.h
Outdated
Show resolved
Hide resolved
src/protocols/user_directed_commissioning/UserDirectedCommissioning.h
Outdated
Show resolved
Hide resolved
src/protocols/user_directed_commissioning/UserDirectedCommissioning.h
Outdated
Show resolved
Hide resolved
|
PR #40696: Size comparison from ad7752d to fbf7c6f Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #40696: Size comparison from ad7752d to 034fbad Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40696 +/- ##
==========================================
+ Coverage 50.72% 50.78% +0.06%
==========================================
Files 1356 1358 +2
Lines 99345 99496 +151
Branches 12876 12881 +5
==========================================
+ Hits 50396 50534 +138
- Misses 48949 48962 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #40696: Size comparison from ad7752d to 5898336 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
sharadb-amazon
approved these changes
Aug 22, 2025
chrisdecenzo
changed the title
|
PR #40696: Size comparison from ad7752d to 33cae5d Increases above 0.2%:
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
| @@ -476,6 +480,7 @@ matter::casting::core::IdentificationDeclarationOptions * convertIdentificationD | |||
| cppIdOptions->mCommissionerPasscode = env->GetBooleanField(jIdOptions, commissionerPasscodeField); | |||
| cppIdOptions->mCommissionerPasscodeReady = env->GetBooleanField(jIdOptions, commissionerPasscodeReadyField); | |||
| cppIdOptions->mCancelPasscode = env->GetBooleanField(jIdOptions, cancelPasscodeField); | |||
| cppIdOptions->mPasscodeLength = env->GetIntField(jIdOptions, passcodeLengthField); | |||
There was a problem hiding this comment.
INFO ../../examples/tv-casting-app/android/App/app/src/main/jni/cpp/support/Converters-JNI.cpp:483:53: error: implicit conversion loses integer precision: 'jint' (aka 'int') to 'uint8_t' (aka 'unsigned char') [-Werror,-Wimplicit-int-conversion]
INFO 483 | cppIdOptions->mPasscodeLength = env->GetIntField(jIdOptions, passcodeLengthField);
INFO | ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO 1 error generated.
pgregorr-amazon
approved these changes
Aug 23, 2025
|
PR #40696: Size comparison from ad7752d to 7f764a7 Increases above 0.2%:
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new passcodeLength field in CDC field
Update PasscodeService to return both a passcode and a display length
Addresses https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/12129
Testing