Increase unit test coverage of credentials/attestation_verifier/ by 16.7%
#40702
+274
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the device attestation verifier module to increase test coverage from 71% to 87.7%. The tests focus on verifying default stub behavior, field copying functionality, error handling, and description mapping.
Key changes:
- Added complete test coverage for unimplemented verifier stub methods
- Added validation tests for attestation info field copying into device info structures
- Added comprehensive testing of error description mapping for all enum values
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TestDeviceAttestationVerifier.cpp | New comprehensive test file covering default verifier stubs, field copying, null handling, and error descriptions |
| BUILD.gn | Added the new test file to the build configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly increases the unit test coverage for the credentials/attestation_verifier/ directory by adding a new test file with comprehensive tests for default verifier stubs, data copying, and error handling. The new tests are well-structured and cover a good range of scenarios. I have one suggestion to improve the code by using the idiomatic data_equal method for ByteSpan comparisons, which enhances readability and safety.
LyudmilaKostanyan
force-pushed
the
DeviceAttestationVerifier
branch
from
62bc960 to
397e1ef
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request significantly increases unit test coverage for the credentials/attestation_verifier/ directory by adding a new suite of tests. The new tests are well-structured and cover the intended scenarios, such as default verifier stub behavior, data copying in AttestationInfo, and error handling logic. The changes are a valuable addition to the codebase. I have one suggestion to improve the robustness of a test case to prevent a potential memory safety issue if the test is extended in the future.
LyudmilaKostanyan
force-pushed
the
DeviceAttestationVerifier
branch
from
019544b to
755e82a
Compare
|
PR #40702: Size comparison from c2f7ddb to 755e82a Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40702 +/- ##
==========================================
+ Coverage 50.78% 50.90% +0.11%
==========================================
Files 1358 1358
Lines 99477 99487 +10
Branches 12877 12875 -2
==========================================
+ Hits 50521 50639 +118
+ Misses 48956 48848 -108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LyudmilaKostanyan
force-pushed
the
DeviceAttestationVerifier
branch
from
755e82a to
13eb5a8
Compare
|
PR #40702: Size comparison from f1631b6 to 13eb5a8 Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
- Added UnimplementedDACVerifierStub test - Added AttestationDeviceInfoCopiesFields test - Added SetDeviceAttestationVerifierNullptrArgument test - Added AttestationResultDescription test - Added SetRevocationDelegate test - Integrated the file into the build
LyudmilaKostanyan
force-pushed
the
DeviceAttestationVerifier
branch
from
13eb5a8 to
73f85d0
Compare
|
PR #40702: Size comparison from 71aed77 to 73f85d0 Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR increases
credentials/attestation_verifier/unit test coverage from 71% to 87.7% by adding additional unit tests that verify the behavior of default verifier stubs, object field initialization, and error description logic.The new tests cover the following scenarios:
AttestationVerificationResultenum value maps to a human-readable string description, and verifies the fallback description for unknown enum values.Related issues
Main issue: #37234
Testing
This PR only adds new unit tests. No changes were made to production code.