[AVSUM] Test script fixes to align with the test plan, fix errors #40712
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a couple of issues in the AVSUM test scripts. It corrects the valid range for the ZoomMax attribute in TC_AVSUM_2_1.py and fixes several incorrect step references in the test descriptions within TC_AVSUM_2_2.py. The changes are generally correct and improve the test suite. I have provided a couple of suggestions: one to improve an assertion message for better diagnostics, and another to fix a typo in a test step description that was missed during the update.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
PR #40712: Size comparison from f1631b6 to a3ee5ee Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40712 +/- ##
=======================================
Coverage 50.71% 50.72%
=======================================
Files 1355 1356 +1
Lines 99303 99345 +42
Branches 12877 12876 -1
=======================================
+ Hits 50366 50396 +30
- Misses 48937 48949 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address one technical and a set of editorial issues.
AVSUM_2_1: correct the range against which ZoomMax is being verified
AVSUM_2_2: correct the step references in the step descriptions
Related issues
Fixes #39932
Testing
Re-run impacted TCs using the Python runner
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines