Skip to content

docs: fix dead links to kenreitz.org #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2025
Merged

docs: fix dead links to kenreitz.org #6951

merged 3 commits into from
Jun 1, 2025

Conversation

tswast
Copy link
Contributor

@tswast tswast commented May 21, 2025

I noticed a few dead links. Looking back through the wayback machine, I was able to find the new location of these articles.

@tswast
Copy link
Contributor Author

tswast commented May 30, 2025

@duzhuoshanwai perhaps you could take a look since you most recently touched this documentation? Thanks!

@tswast
Copy link
Contributor Author

tswast commented May 30, 2025

Or maybe @nateprewitt who reviewed #6899

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I'd prefer we just remove these links. We get PRs every few years whenever the domain changes.

@duzhuoshanwai
Copy link
Contributor

Shouldn't we asking kennethreitz himself, since this is his website?

Co-authored-by: Nate Prewitt <[email protected]>
@tswast
Copy link
Contributor Author

tswast commented Jun 1, 2025

I think there's some useful information in both of those remaining links. Maybe I try to paraphrase or summarize to include them directly on the docs site?

@sigmavirus24
Copy link
Contributor

Be cordial or be on your way, isn't a code of conduct and being under the PSF we adhere to that. We should instead link to that CoC

@sigmavirus24
Copy link
Contributor

Also the post about the future from 13 years ago, isn't relevant any longer. We just haven't edited and pruned our docs in a long while to remove references to it

@tswast
Copy link
Contributor Author

tswast commented Jun 1, 2025

Thanks for the feedback! Indeed, as I look deeper into the Transport Adapters justification, it doesn't appear that the original vision of unifying WGSI, Flask, Requests, etc. with common base classes wasn't actually achieved, so that document may be doing more harm than good at this point.

Removed both of the remaining links in 6716d7c

@nateprewitt nateprewitt merged commit 7341690 into psf:main Jun 1, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants