Document HTTPX2 instrumentation#2104
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe HTTPX integration documentation now covers both HTTPX and HTTPX2, including installation requirements, usage examples, client selection, troubleshooting, compatibility guidance, and reference links. The integrations table and navigation label were also updated from “HTTPX” to “HTTPX and HTTPX2” without changing the instrumentation call or destination link. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/integrations/http-clients/httpx.md`:
- Around line 13-14: Update the introductory statement around
logfire.instrument_httpx() to qualify that both HTTPX libraries are instrumented
only when opentelemetry-instrumentation-httpx is version 0.65b0 or newer; note
that older versions warn and skip HTTPX2 while preserving the existing
single-library behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ffbdba44-97c5-4a69-8572-84d08932ff9d
📒 Files selected for processing (3)
docs/integrations/http-clients/httpx.mddocs/integrations/index.mddocs/nav.json
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
pydantic/logfire(manual)pydantic/pydantic-ai(manual)pydantic/platform(auto-detected)pydantic/pydantic(auto-detected)
Summary
logfire.instrument_httpx()supports both HTTPX and HTTPX2Validation
uv run pytest tests/test_docs.py -q(125 passed)docs/nav.jsonwithpython -m json.toolThe documentation changes were drafted with Codex and reviewed against the merged implementation and the repository documentation style guide.