Skip to content

Document HTTPX2 instrumentation#2104

Merged
alexmojaki merged 4 commits into
mainfrom
codex/docs-httpx2
Jul 24, 2026
Merged

Document HTTPX2 instrumentation#2104
alexmojaki merged 4 commits into
mainfrom
codex/docs-httpx2

Conversation

@alexmojaki

Copy link
Copy Markdown
Contributor

Summary

  • document that logfire.instrument_httpx() supports both HTTPX and HTTPX2
  • explain that global instrumentation covers both installed libraries while a client argument targets one client
  • clarify that the Logfire extra installs neither HTTP client
  • document the HTTPX2 OpenTelemetry version requirement and compatible upgrade command
  • make HTTPX2 discoverable in the integrations index and navigation

Validation

  • uv run pytest tests/test_docs.py -q (125 passed)
  • validated docs/nav.json with python -m json.tool
  • smoke-tested global instrumentation with HTTPX and HTTPX2 mock transports

The documentation changes were drafted with Codex and reviewed against the merged implementation and the repository documentation style guide.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread docs/integrations/http-clients/httpx.md
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The HTTPX integration documentation now covers both HTTPX and HTTPX2, including installation requirements, usage examples, client selection, troubleshooting, compatibility guidance, and reference links. The integrations table and navigation label were also updated from “HTTPX” to “HTTPX and HTTPX2” without changing the instrumentation call or destination link.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: adding HTTPX2 instrumentation documentation.
Description check ✅ Passed The description clearly matches the documented HTTPX/HTTPX2 instrumentation updates and related docs/navigation changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/docs-httpx2

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/integrations/http-clients/httpx.md`:
- Around line 13-14: Update the introductory statement around
logfire.instrument_httpx() to qualify that both HTTPX libraries are instrumented
only when opentelemetry-instrumentation-httpx is version 0.65b0 or newer; note
that older versions warn and skip HTTPX2 while preserving the existing
single-library behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ffbdba44-97c5-4a69-8572-84d08932ff9d

📥 Commits

Reviewing files that changed from the base of the PR and between 692ec02 and e38858e.

📒 Files selected for processing (3)
  • docs/integrations/http-clients/httpx.md
  • docs/integrations/index.md
  • docs/nav.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • pydantic/logfire (manual)
  • pydantic/pydantic-ai (manual)
  • pydantic/platform (auto-detected)
  • pydantic/pydantic (auto-detected)

Comment thread docs/integrations/http-clients/httpx.md Outdated
@alexmojaki
alexmojaki enabled auto-merge (squash) July 24, 2026 16:31
@alexmojaki
alexmojaki merged commit e1f9db9 into main Jul 24, 2026
16 checks passed
@alexmojaki
alexmojaki deleted the codex/docs-httpx2 branch July 24, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant