Skip to content

fix: write relative schema refs for AgentSpec files #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hramezani merged 3 commits into from
Jul 6, 2026
+47 −1
Merged

fix: write relative schema refs for AgentSpec files #6251

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25e490d
fix: write relative `$schema` for local `AgentSpec.to_file` schemas
VectorPeak Jul 3, 2026
27d4ef1
test: cover AgentSpec YAML schema refs
VectorPeak Jul 3, 2026
3c6cb1f
test: cover external AgentSpec schema refs
VectorPeak Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pydantic_ai_slim/pydantic_ai/agent/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ def to_file(
if not schema_path.is_absolute():
schema_ref = str(schema_path)
schema_path = path.parent / schema_path
else: # pragma: no cover
elif schema_path.is_relative_to(path.parent):
schema_ref = str(schema_path.relative_to(path.parent))
else:
schema_ref = str(schema_path)
self._save_schema(schema_path, custom_capability_types)

Expand Down
14 changes: 14 additions & 0 deletions tests/test_capabilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2127,6 +2127,20 @@ def test_to_file_json(tmp_path: str):
assert schema_path.exists()


def test_to_file_json_with_absolute_schema_path(tmp_path: str):
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
import json

spec = AgentSpec(model='test', name='my-agent')
spec_path = Path(tmp_path) / 'agent.json'
schema_path = Path(tmp_path) / 'agent_schema.json'

spec.to_file(spec_path, schema_path=schema_path)

data = json.loads(spec_path.read_text(encoding='utf-8'))
assert data['$schema'] == 'agent_schema.json'
assert schema_path.exists()


def test_to_file_no_schema(tmp_path: str):
spec = AgentSpec(model='test')
spec_path = Path(tmp_path) / 'agent.yaml'
Expand Down
Loading