Skip to content

fix(evals): reject non-positive OnlineEvaluator.max_concurrency #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adtyavrdhn merged 3 commits into from
Jul 6, 2026
Merged

fix(evals): reject non-positive OnlineEvaluator.max_concurrency #6267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1b2918
fix(evals): validate online evaluator max concurrency
VectorPeak Jul 4, 2026
09b3d58
Merge branch 'main' into fix-online-evaluator-max-concurrency
VectorPeak Jul 5, 2026
71f2916
Merge branch 'main' into fix-online-evaluator-max-concurrency
adtyavrdhn Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pydantic_evals/pydantic_evals/online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ class OnlineEvaluator:
"""

def __post_init__(self) -> None:
if self.max_concurrency < 1:
raise ValueError(f'max_concurrency must be >= 1, got {self.max_concurrency}')
self.semaphore = threading.Semaphore(self.max_concurrency)


Expand Down
7 changes: 7 additions & 0 deletions tests/evals/test_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,13 @@ async def test_online_evaluator_custom_config():
assert online.max_concurrency == 5


@pytest.mark.parametrize('max_concurrency', [0, -1])
def test_online_evaluator_invalid_max_concurrency(max_concurrency: int):
"""OnlineEvaluator rejects non-positive concurrency limits."""
with pytest.raises(ValueError, match=f'max_concurrency must be >= 1, got {max_concurrency}'):
OnlineEvaluator(evaluator=AlwaysTrue(), max_concurrency=max_concurrency)


@pytest.mark.anyio
async def test_run_evaluators_success():
"""run_evaluators returns results from all evaluators."""
Expand Down
Loading