Skip to content
This repository was archived by the owner on Apr 11, 2026. It is now read-only.

fix: use validator name instead of tag value in tagged union error loc#1897

Closed
JaeHyuckSa wants to merge 1 commit into
pydantic:mainfrom
JaeHyuckSa:fix-issue-10433
Closed

fix: use validator name instead of tag value in tagged union error loc#1897
JaeHyuckSa wants to merge 1 commit into
pydantic:mainfrom
JaeHyuckSa:fix-issue-10433

Conversation

@JaeHyuckSa

@JaeHyuckSa JaeHyuckSa commented Jan 20, 2026

Copy link
Copy Markdown

Change Summary

Tagged union errors currently show the discriminator’s tag value (e.g., apple, tag_for_a) in loc. This change makes them show the validator name instead (e.g., typed-dict).

Related issue number

fix: pydantic/pydantic#10433

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codecov

codecov Bot commented Jan 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/validators/union.rs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codspeed-hq

codspeed-hq Bot commented Jan 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 163 untouched benchmarks


Comparing JaeHyuckSa:fix-issue-10433 (b8d44b0) with main (383eb95)

Open in CodSpeed

Signed-off-by: JaeHyuck Sa <wogur981208@gmail.com>
@JaeHyuckSa

Copy link
Copy Markdown
Author

This was accidentally opened against the wrong repository. I’ve fixed it and opened a new PR for Pydantic instead.

@JaeHyuckSa JaeHyuckSa closed this Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible bug with error messages from callable discriminators

1 participant