Restores compatibility shim with platform.linux_distribution#325
Merged
Conversation
HorlogeSkynet
force-pushed
the
fix/linux_distribution_id_regression
branch
from
February 12, 2022 13:35
c39caf0 to
2871ef3
Compare
hartwork
reviewed
Feb 12, 2022
Contributor
|
Are we able to revert #230 first to ensure we're restoring compatibility and then evaluate what to do next? |
Contributor
@sethmlarson it's pretty big and in for 2 years. I'm not sure I'd vote for that path. What's the idea? |
Member
Author
HorlogeSkynet
force-pushed
the
fix/linux_distribution_id_regression
branch
from
February 13, 2022 10:52
2871ef3 to
68c163c
Compare
hartwork
reviewed
Feb 13, 2022
added 2 commits
February 13, 2022 17:58
distro#230 introduced proper support for os-release `VERSION_CODENAME` attribute but broke compatibility shim with (now defunct) `platform.linux_distribution` as the third tuple member (codename) were not taken from `VERSION` os-release attribute anymore. Closes #238.
HorlogeSkynet
force-pushed
the
fix/linux_distribution_id_regression
branch
from
February 13, 2022 16:59
68c163c to
fa43a62
Compare
hartwork
approved these changes
Feb 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#230 introduced proper support for os-release
VERSION_CODENAMEattribute but broke compatibility shim with (now defunct)platform.linux_distributionas the third tuple member (codename) were not taken fromVERSIONos-release attribute anymore.Closes #238.