Skip to content

Arm backend: Move TOSA operators to dialect #13408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

per
Copy link
Collaborator

@per per commented Aug 14, 2025

Summary

Move rescale, table and transpose TOSA operators to new implementation.

Test plan

Tested through existing CI unit tests.

cc @digantdesai @freddan80 @zingo @oscarandersson8218

per added 2 commits August 14, 2025 08:59
Signed-off-by: Per Åstrand <[email protected]>

Change-Id: I2409cbbf1e96f3c4acc5502fe8c49e6a163a3fe3
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I9e2b03cfafba03decc364034ef3d8c06b73b93ae
@per per requested a review from digantdesai as a code owner August 14, 2025 07:55
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Aug 14, 2025
Copy link

pytorch-bot bot commented Aug 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13408

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures, 40 Unrelated Failures

As of commit 939d094 with merge base 30a6f5e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2025
)


@register_tosa_op(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit for

Suggested change
@register_tosa_op(
@register_fake_tosa_op(

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. I wanted to do this for xnnpack (i.e. a backend dialect) for at least two years now 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants