-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Dev UI: New Settings page with Storage management and storage per app #49496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev UI: New Settings page with Storage management and storage per app #49496
Conversation
🙈 The PR is closed and the preview is expired. |
645908e
to
5017f9f
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This comment has been minimized.
This comment has been minimized.
5017f9f
to
a61f200
Compare
Signed-off-by: Phillip Kruger <[email protected]>
a61f200
to
f7a40de
Compare
This comment has been minimized.
This comment has been minimized.
f7a40de
to
7d51c69
Compare
This comment has been minimized.
This comment has been minimized.
…se those Signed-off-by: Phillip Kruger <[email protected]>
7d51c69
to
8170487
Compare
Status for workflow
|
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
❌ | JVM Tests - JDK 17 | Clean Gradle temp directory |
Logs | Raw logs | 🚧 | |
✔️ | JVM Tests - JDK 21 | Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Flaky tests - Develocity
⚙️ JVM Tests - JDK 21
📦 extensions/smallrye-reactive-messaging-kafka/deployment
❌ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1
- History
expected: <1> but was: <0>
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:166)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:161)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:632)
at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1(KafkaDevServicesContinuousTestingTestCase.java:64)
Partly fix #49457
This PR introduce a new narrower scope for the Dev UI Storage controller. At the moment the storage controller is scoped per extension (by default). This PR allows extension developers to narrow the scope to per extension per application.
This PR also introduce a new Settings screen that moves the theme and bug reporting to this screen, but also allows users to manage all storage. It also allows extension developers to react on manual storage removal.
Screencast_20250813_105219.mp4
Of course extension developers can build their own screens/buttons that remove/clear their own storage. This is more raw and in general.
I also added 2 more page type to Dev UI (apart from the normal Card, Menu and Footer) you can now add a SettingsPage (that will add a tab in the settings screen) and an UnlistedPage (that won't be listed anywhere, but will be added to the router and you can manually (in your extension code) navigate there using either the url or the Router controller.
I also then moved the Dev MCP pages to settings (that makes more sense there) and changed the enable of Dev MCP to NOT be in the config (as this will enable it on other people's laptops and they might not want it) and rather to it per laptop.
dev_ui_mcp_settings.mp4
I added the documentation for the storage controller, and the Dev UI documentation with the 2 new page types. I also updated the Dev MCP documentation with the changes.