Avoid now unnecessary copy of MethodInfo in Methods #49526
Merged
+10
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also avoid calling method.name() several times, it's not a big improvement but it doesn't hurt.
|
CI is all green in my branch so marking it as ready for review. |
Ladicek
approved these changes
Aug 14, 2025
manovotn
approved these changes
Aug 14, 2025
This comment has been minimized.
This comment has been minimized.
💯 Yes, that's exactly what I mentioned in the zulip discussion . |
mkouba
approved these changes
Aug 15, 2025
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mkouba did some archeology and it seems we were doing some changes to the
MethodInfopre-0.16.0 but we are now passing it unchanged as far as we could see.The point of the change is to reduce the allocations during the build of large codebases.
Also avoid calling method.name() several times, it's not a big improvement but it doesn't hurt.