GHA TESTS - Improve logging to group in the right place - #13807
Merged
Conversation
cderv
marked this pull request as draft
December 17, 2025 13:34
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Member
Author
|
Here is the new state Playwright tests loggingAll test is grouped, but failure is shown outside the group 
Then inside the group we get logging about each document render in pre-test step Then the playwright logging itself is at its minimum (dot reporter) with error shown after 
smoke test loggingEach test is grouped and error shows below the failing grouped test with summary at the end Unfolding shows the details Same for smoke-all document Still small tweaks but this is better. #13808 will also help reduce the Deno logging about dependencies download. |
Adds fallback behavior to src/tools/github.ts for local development: - error/warning/notice functions now print to console when not in GHA - withGroup/withGroupAsync print titles directly instead of using workflow commands
Adds automatic DEBUG level logging when RUNNER_DEBUG=1 is set in GitHub Actions environment. Can be overridden by explicit --log-level or QUARTO_LOG_LEVEL environment variable.
- Suppress webServer output (stderr: 'ignore' in playwright.config.ts) - Add respectStreams: true to execProcess for clearer test output - Add environment variables for test flexibility (SKIP_RENDER, SKIP_CLEANOUTPUT) - Improve document rendering logging with relative paths
cderv
force-pushed
the
gha/improve-logging
branch
from
December 19, 2025 14:59
d8c8fc3 to
d1fa9c1
Compare
- Add ::group::/::endgroup:: around test file execution in test-smokes.yml - Remove QUARTO_LOG_LEVEL: DEBUG from workflow - Remove unnecessary echo statements from run-tests.sh GitHub Actions doesn't support nested groups, so only workflow-level grouping is used.
Adds three intentionally failing tests to validate that grouping improvements work correctly in CI logs: - Playwright test (tests/integration/playwright/tests/) - Unit test (tests/unit/) - Smoke-all document (tests/docs/smoke-all/) These tests should be removed after verifying CI log behavior.
This reverts commit 85ffd0d.
cderv
force-pushed
the
gha/improve-logging
branch
from
December 19, 2025 15:03
d1fa9c1 to
f664f1c
Compare
cderv
marked this pull request as ready for review
December 19, 2025 15:03
cderv
added a commit
to cderv/quarto-cli
that referenced
this pull request
Jul 20, 2026
The bucketed CI runs got navigable logs by wrapping each file in a ::group:: at the workflow level (quarto-dev#13787/quarto-dev#13807), but the default non-bucketed run is one giant deno test whose thousands of flat lines have no structure. Have the harness itself open a group per test file so that path collapses the same per-test noise the bucket loop does. Grouping lives in a small state machine (gha-grouping.ts) so the single-open-group invariant — the GitHub runner cannot nest groups — is enforced and unit-testable in isolation. The harness opens/transitions the group at the start of each test's fn, closes it on the failure path before fail() throws (so the FAILED line and ::error land outside the collapsed group), and closes any open group at unload before the Phase 1 aggregate error and Deno's terminal ERRORS/FAILURES sections. Every emission is gated on harnessOwnsStep() (on CI, no outer orchestrator), the same ownership switch Phase 1 uses: local runs and orchestrated bucket runs stay byte-identical, so the quarto-dev#13807 bucket log format is untouched. Closure is lazy per file; direct Deno.test files are a documented exemption. Design and invariants: dev-docs/ci-test-log-grouping-design.md.
cderv
added a commit
to cderv/quarto-cli
that referenced
this pull request
Jul 20, 2026
The bucketed CI runs got navigable logs by wrapping each file in a ::group:: at the workflow level (quarto-dev#13787/quarto-dev#13807), but the default non-bucketed run is one giant deno test whose thousands of flat lines have no structure. Have the harness itself open a group per test file so that path collapses the same per-test noise the bucket loop does. Grouping lives in a small state machine (gha-grouping.ts) so the single-open-group invariant — the GitHub runner cannot nest groups — is enforced and unit-testable in isolation. The harness opens/transitions the group at the start of each test's fn, closes it on the failure path before fail() throws (so the FAILED line and ::error land outside the collapsed group), and closes any open group at unload before the Phase 1 aggregate error and Deno's terminal ERRORS/FAILURES sections. Every emission is gated on harnessOwnsStep() (on CI, no outer orchestrator), the same ownership switch Phase 1 uses: local runs and orchestrated bucket runs stay byte-identical, so the quarto-dev#13807 bucket log format is untouched. Closure is lazy per file; direct Deno.test files are a documented exemption. Design and invariants: dev-docs/ci-test-log-grouping-design.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up previous one #13787 by trying to group in a more scoped place.