add linuxquic implementation and enable it in ci #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add linuxquic-interop docker image in implementations.json, and skip it if kernel module doesn't exists in implementations.py. Signed-off-by: Xin Long <[email protected]>
This reusable workflow groups interop tests by client, improving organization. More importantly, it works around the 256-job limit in the GitHub Actions' matrix strategy, allowing additional images to be included in implementations.json. This approach requires minimal changes to interop.yml, primarily moving the tests section into interop-tests.yml. The workflow now matrices over all clients, passing a single client and all servers to interop-tests.yml per run. Suggested-by: Lars Eggert <[email protected]> Signed-off-by: Xin Long <[email protected]>
Install the Linux QUIC module in CI interop tests when either the client or server is Linux QUIC, ensuring its availability in interop CI. Note if the kernel already supports QUIC, running make -C modules install will have no effect on the host. Signed-off-by: Xin Long <[email protected]>
|
@lxin I tried to add |
|
@larseggert Oh, I just checked your commit. As linuxquic implement QUIC in kernel, you need to install the QUIC kernel module on the host, as it does in the patch "ci: enable linuxquic in interop tests ". |
|
@larseggert FYI, The result of the interop test I ran with this patchset on Mar 9th:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset integrates linuxquic into the quic interop runner and enables it in CI.
With this patchset, interop tests CI can now run successfully with additional images, as shown in https://github.com/lxin/quic-interop-runner/actions/runs/13320422050
Thanks to Moritz Buhl for initiating the interop tests for linuxquic.