normalize color names by removing spaces before lookup#17
Closed
AlexKnauth wants to merge 1 commit into
Closed
Conversation
Previously the find-color method of the color database normalized only by downcasing. Now it downcases and removes spaces, except for "cadet blue" and "cornflower blue".
AlexKnauth
force-pushed
the
normalize-remove-spaces
branch
from
January 22, 2019 14:33
471d812 to
d0c0549
Compare
Member
|
This looks good to me except that it needs a documentation update (preferably with some examples that highlight the strangeness of the two special cases). |
Contributor
|
I am fine with this. We'll see whether anyone hollers about 2htdp/image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the find-color method of the color database normalized only by downcasing. Now it downcases and removes spaces, except for "cadet blue" and "cornflower blue", which it leaves as-is.