Rename closed category/thread permission checks #1980
+78
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permissions check_post_in_closed_category_permission and check_post_in_closed_thread_permission have been renamed to check_locked_category_permission and check_locked_thread_permission respectively
rafalp
added
area: docs
area: backend
rafalp
requested changes
Aug 14, 2025
| @@ -28,11 +28,11 @@ | |||
| from .check_edit_thread_poll_permission import check_edit_thread_poll_permission_hook | |||
| from .check_edit_thread_post_permission import check_edit_thread_post_permission_hook | |||
| from .check_open_thread_poll_permission import check_open_thread_poll_permission_hook | |||
| from .check_post_in_closed_category_permission import ( | |||
| check_post_in_closed_category_permission_hook, | |||
| from .check_locked_category_permission import ( | |||
| @@ -103,8 +103,8 @@ | |||
| "check_edit_thread_poll_permission_hook", | |||
| "check_edit_thread_post_permission_hook", | |||
| "check_open_thread_poll_permission_hook", | |||
| "check_post_in_closed_category_permission_hook", | |||
| "check_post_in_closed_thread_permission_hook", | |||
| "check_locked_category_permission_hook", | |||
There was a problem hiding this comment.
Please order this list alphabetically
dev-docs/plugins/hooks/reference.md
Outdated
| @@ -85,8 +85,8 @@ Hooks instances are importable from the following Python modules: | |||
| - [`check_edit_thread_poll_permission_hook`](./check-edit-thread-poll-permission-hook.md) | |||
| - [`check_edit_thread_post_permission_hook`](./check-edit-thread-post-permission-hook.md) | |||
| - [`check_open_thread_poll_permission_hook`](./check-open-thread-poll-permission-hook.md) | |||
| - [`check_post_in_closed_category_permission_hook`](./check-post-in-closed-category-permission-hook.md) | |||
| - [`check_post_in_closed_thread_permission_hook`](./check-post-in-closed-thread-permission-hook.md) | |||
| - [`check_locked_category_permission_hook`](./check-post-in-closed-category-permission-hook.md) | |||
There was a problem hiding this comment.
Run python generate_dev_docs.py in main directory instead of manually updating hooks reference.
rafalp
changed the title
|
Build is failing, please format code with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1955
Misago permission checks:
Had been renamed to:
Including a couple file names.